Skip to content

fix(tabs): replace igx-icon with igc-icon in WC demo + fix theme parameters #16395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 18, 2025
Merged

fix(tabs): replace igx-icon with igc-icon in WC demo + fix theme parameters #16395

merged 13 commits into from
Nov 18, 2025

Conversation

@adrianptrv
Copy link
Contributor

@adrianptrv adrianptrv commented Oct 29, 2025 •
edited
Loading

Related to: #1915
Requires this theming PR: 495

  • Replaced igx-icon with igc-icon in the WC Tabs demo.
  • Fixed the $border-radius theme parameter so it works correctly.
  • Updated $item-background to apply only to Tab items instead of both Tab items and the Tab Header.
  • Set up the three new theme parameters - $item-active-hover-background $item-active-hover-color $item-active-hover-icon-color

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@adrianptrv adrianptrv requested a review from simeonoff October 29, 2025 19:38
@adrianptrv adrianptrv mentioned this pull request Oct 29, 2025
Merged
didimmova
didimmova previously approved these changes Oct 30, 2025
View reviewed changes
@didimmova didimmova added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 30, 2025
@adrianptrv adrianptrv changed the title fix(tabs): replace igx-icon with igc-icon in WC demo fix(tabs): replace igx-icon with igc-icon in WC demo + fix theme parameters Nov 2, 2025
@adrianptrv adrianptrv added ❌ status: awaiting-test PRs awaiting manual verification and removed ✅ status: verified Applies to PRs that have passed manual verification labels Nov 4, 2025
@adrianptrv adrianptrv assigned desig9stein and unassigned didimmova Nov 4, 2025
@desig9stein
Copy link
Contributor

desig9stein commented Nov 4, 2025

THEME: INDIGO
It looks like item-active-background is not used anywhere in the Indigo theme. Its current value also seems incorrect: when I apply it in the expected place, it renders as transparent. I believe it should use the same color as the item-hover-background, since that’s what is currently used in that state.

@adrianptrv adrianptrv mentioned this pull request Nov 10, 2025
Merged
@adrianptrv
Copy link
Contributor Author

adrianptrv commented Nov 10, 2025

THEME: INDIGO It looks like item-active-background is not used anywhere in the Indigo theme. Its current value also seems incorrect: when I apply it in the expected place, it renders as transparent. I believe it should use the same color as the item-hover-background, since that’s what is currently used in that state.

I have added and set up three new parameters for the active tab - $item-active-hover-background $item-active-hover-color $item-active-hover-icon-color
The changes can now be tested again using this theming PR: 495

@desig9stein
Copy link
Contributor

desig9stein commented Nov 11, 2025

@adrianptrv, the active background is still not working. I should be able to see the active background on the active tab in the idle state and the active hover background when I hover the active tab.

@desig9stein desig9stein added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 14, 2025
@simeonoff simeonoff merged commit fbfd883 into master Nov 18, 2025
7 of 11 checks passed
@simeonoff simeonoff deleted the apetrov/fix-tabs-demo-icon branch November 18, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didimmova didimmova didimmova left review comments

@simeonoff simeonoff Awaiting requested review from simeonoff

Assignees

@desig9stein desig9stein

Labels

demos tabs version: 21.0.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adrianptrv @desig9stein @didimmova @simeonoff